[PATCH] Run tst-fopenloc if $(build-shared) is yes

[Andreas Jaeger]

On 09/10/2012 08:15 PM, H.J. Lu wrote:
> On Mon, Sep 10, 2012 at 6:59 AM, Andreas Jaeger <aj@suse.com> wrote:
>> On Monday, September 10, 2012 06:42:49 H.J. Lu wrote:
>>> On Mon, Sep 10, 2012 at 6:31 AM, Andreas Jaeger <aj@suse.com> wrote:
>>>> On Monday, September 10, 2012 06:24:35 H.J. Lu wrote:
>>>>> Hi,
>>>>>
>>>>> tst-fopenloc depends on shared localedata objects and
>>>>> tst-fopenloc.check depends on tst-fopenloc.  This patch enables
>>>>> them
>>>>> only if $(build-shared) is yes.  OK to install.
>>>>
>>>> We haven't done this in the past but since you're touching all of
>>>> this, a suggestion from my side: Add to each of these Makefile an
>>>> explanation why tests are disabled.
>>>
>>> Thanks for the feedback.
>>>
>>>> This is even not clear from your changelog, it only says "Add tst-
>>>> fopenloc" - I suggest to say "Add test-fopenloc since it depends on
>>>> shared localedata objects."
>>>
>>> Is this an approval with those comments added?
>>
>> Yes,
>
> This is what I checked.  Are my other similar changes OK with
> similar comments added?
>
> Thanks.
>
>

Just a quick comment:

> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,5 +1,11 @@
>  2012-09-10  H.J. Lu  <hongjiu.lu@intel.com>
>
> +	* libio/Makefile: Include ../Makeconfig before tests.
> +	(tests): Add tst-fopenloc and depend on $(objpfx)tst-fopenloc.check
> +	only if $(build-shared) is yes.
> +
> +2012-09-10  H.J. Lu  <hongjiu.lu@intel.com>
> +

If you have several changes on the same day after each other, please 
remove your name, just have:

2012-09-10 ...

    * libio/Makefile
<empty line here>
    * previous change

Andreas
-- 
  Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
   SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
    GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
     GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126