[PATCH] Run tst-fopenloc if $(build-shared) is yes

[H.J. Lu]

On Mon, Sep 10, 2012 at 6:31 AM, Andreas Jaeger <aj@suse.com> wrote:
> On Monday, September 10, 2012 06:24:35 H.J. Lu wrote:
>> Hi,
>>
>> tst-fopenloc depends on shared localedata objects and
>> tst-fopenloc.check depends on tst-fopenloc.  This patch enables them
>> only if $(build-shared) is yes.  OK to install.
>
> We haven't done this in the past but since you're touching all of this,
> a suggestion from my side: Add to each of these Makefile an explanation
> why tests are disabled.

Thanks for the feedback.

> This is even not clear from your changelog, it only says "Add tst-
> fopenloc" - I suggest to say "Add test-fopenloc since it depends on
> shared localedata objects."
>

Is this an approval with those comments added?


-- 
H.J.