[Committed] S/390: Make IFUNC optimized mem* functions hidden

Roland McGrath roland@hack.frob.com
Thu Sep 6 19:45:00 GMT 2012


> +  /* Make the declarations of the optimized functions hidden in order
> +     to prevent GOT slots being generated for them. */			\
> +  extern __attribute__((visibility("hidden"))) void *FUNC##_z196;	\
> +  extern __attribute__((visibility("hidden"))) void *FUNC##_z10;	\
> +  extern __attribute__((visibility("hidden"))) void *FUNC##_z900;	\

This attribute syntax has wrong whitespace.
But you should just use the attribute_hidden macro anyway, it's shorter.
Also, it's our convention for declarations to put attributes at the end,
not before the type (before the type is the convention for definitions).


Thanks,
Roland



More information about the Libc-alpha mailing list