Patch: Convert linux-generic to use <bits/fcntl-linux.h>

[Mike Frysinger]

On Wednesday 24 October 2012 16:04:15 Andreas Jaeger wrote:
> On 10/24/2012 09:31 PM, Chris Metcalf wrote:
> > On 10/24/2012 3:05 PM, Andreas Jaeger wrote:
> >> Here's a patch for linux-generic to use <bits/fcntl-linux.h>.
> >> The patch is also part of my git branch aj/shared-linux-fcntl.
> > 
> > Does it make sense to move the O_LARGEFILE definition to
> > bits/fcntl-linux.h instead, i.e. if __O_LARGEFILE is not defined,
> > provide a definition that's conditional on _WORDSIZE?  That seems like a
> > more natural default, particularly as more platforms will be 64-bit with
> > time and thus want zero for O_LARGEFILE.  <bits/wordsize.h> could either
> > be unconditionally included, or just included ifndef __O_LARGEFILE.
> 
> We could have:
> #ifdef __USE_LARGEFILE64
> # if __WORDSIZE == 64
> #  define O_LARGEFILE  0
> # else
> #  define O_LARGEFILE __O_LARGEFILE
> # endif
> #endif

if i'm reading mips' fcntl.h correctly, i don't think that'll work.  you'd 
have to make this the __O_LARGEFILE default rather than O_LARGEFILE.  their 
64bit abis are kind of the suck :/.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20121024/33199823/attachment.sig>