[PATCH v3] change ifunc assembly test to a link test

Roland McGrath roland@hack.frob.com
Wed Oct 24 17:12:00 GMT 2012


>  # For the multi-arch option we need support in the assembler.
>  AC_CACHE_CHECK([for assembler gnu_indirect_function symbol type support],
> -	       libc_cv_asm_gnu_indirect_function, [dnl
> +	       libc_cv_ld_gnu_indirect_function, [dnl

You forgot to change the message (and the comment):

# To use IFUNC for multi-arch or other purposes, we need in the assembler
# and linker.
AC_CACHE_CHECK([for assembler and linker STT_GNU_IFUNC support],

> +  # Do a link to see if the backend supports IFUNC relocs.
> +  $READELF -r conftest 1>&AS_MESSAGE_LOG_FD
> +  LC_ALL=C $READELF -r conftest | grep 'no relocations' >/dev/null || {
> +    libc_cv_ld_gnu_indirect_function=yes
> +  }

This is subject to false-negatives if there is some unexpected weirdness
with readelf or something.  But I'm not too concerned.

The change is OK with the fixes above.


Thanks,
Roland



More information about the Libc-alpha mailing list