[PATCH siddhesh/wait_bitset] Use FUTEX_WAIT_BITSET for pthread_cond_timedwait for non-x86: ppc, s390

Roland McGrath roland@hack.frob.com
Wed Oct 24 00:00:00 GMT 2012


> 	* pthread_cond_timedwait.c (__pthread_cond_timedwait): Timeout
> 	if absolute timeout is negative.

When used as a verb, write "Time out".

> 	* sysdeps/unix/sysv/linux/powerpc/lowlevellock.h
> 	(lll_futex_timed_wait_bitset); Define.
> 	* sysdeps/unix/sysv/linux/s390/lowlevellock.h
> 	(lll_futex_timed_wait_bitset); Likewise.

s/;/:/.  Say "New macro".

> +#if (!defined(__ASSUME_FUTEX_CLOCK_REALTIME) \
> +     || !defined(lll_futex_timed_wait_bitset))

Space before paren, or omit the parens after 'defined' entirely.
They are superfluous here.

The substance of the change looks fine to me, but it needs powerpc and s390
folks to look at it.


Thanks,
Roland



More information about the Libc-alpha mailing list