[RFC] FIPS compliance and other crypt(3) improvements

[Alexandre Oliva]

On Oct  2, 2012, Roland McGrath <roland@hack.frob.com> wrote:

>> +static bool
>> +bad_for_salt (c)
>> +     char c;

> Use a prototype defn.

Even in a file that's K&R?  Ok, I removed the now-redundant prototype
declaration, too.

> This looks like a log entry more than a NEWS entry.  
> A NEWS entry should describe things meaningful to a user:

Heh.  Indeed.  Thanks for the review and the NEWS entry.

Here's the revised, retested patchset I'm going to check in some 24+h
from now, if I don't get objections.  It's also available in branch
lxoliva/crypt-fips-bz811753.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 01-crypt-badsalt-bz811753.patch
Type: text/x-diff
Size: 6726 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20121003/0eea4ab8/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 02-crypt-fipsalgo-bz811753.patch
Type: text/x-diff
Size: 6720 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20121003/0eea4ab8/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 03-crypt-news-bz811753.patch
Type: text/x-diff
Size: 839 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20121003/0eea4ab8/attachment-0002.bin>
-------------- next part --------------


-- 
Alexandre Oliva, freedom fighter    http://FSFLA.org/~lxoliva/
You must be the change you wish to see in the world. -- Gandhi
Be Free! -- http://FSFLA.org/   FSF Latin America board member
Free Software Evangelist      Red Hat Brazil Compiler Engineer