[PATCH 2/3 elf] Add MicroBlaze support to elf.h

Andreas Jaeger aj@suse.com
Thu Nov 29 08:04:00 GMT 2012


On 11/29/2012 08:58 AM, Mike Frysinger wrote:
> On Thursday 29 November 2012 02:16:22 Andreas Jaeger wrote:
>> On 11/29/2012 06:28 AM, David Holsgrove wrote:
>>> +#define EM_NEW_MICROBLAZE   0xbd /* Xilinx MicroBlaze */
>>> +#define EM_MICROBLAZE 0xbaab
>>
>> Are any of these official values? The comment above asks for hig numbers
>> and 0xbd is not height.
>
> the first one is, but should be renamed.  from binutils:
> #define EM_MICROBLAZE   189 /* Xilinx MicroBlaze 32-bit RISC soft processor core */

In that case, it should be sorted at the proper place - directly after 
EM_TILEPRO.

David, we've just frozen glibc for development, these kind of patches 
are too late for glibc 2.17. Please update them and they will get 
properly reviewed and added once 2.17 is released.

Btw. do you have copyright announcement with the FSF?
Andreas
-- 
  Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
   SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
    GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
     GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126



More information about the Libc-alpha mailing list