Use unmodified tzselect.ksh in glibc

Roland McGrath roland@hack.frob.com
Fri Nov 9 22:55:00 GMT 2012


> +	sed -e 's|/bin/bash|$(KSH)|g' \
> +	    -e 's|TZDIR=\$$(pwd)|TZDIR=$(zonedir)|g' \
> +	    -e 's|see_Makefile|"$(PKGVERSION)$(version)"|g' < $< > $@.new

This is probably fine as is, but I'd be inclined to tighten it up a bit.
Things are not as we expect if (at least for the last two) if they might
match more than once, so drop "g".  My inclination would be:

	-e '/TZDIR=/s|\$$(pwd)|$(zonedir)|' \
	-e '/TZVERSION=/s|see_Makefile|"$(PKGVERSION)$(version)"|' \
	< $< > $@.new

And we usually use an extra continuation line like that when one or both
parts (here both) are likely to wind up much longer in the make output
than they are in the source.

Such nits aside, the change is good.


Thanks,
Roland



More information about the Libc-alpha mailing list