[PATCH siddhesh/wait_bitset] Use FUTEX_WAIT_BITSET for pthread_cond_timedwait for non-x86: ppc, s390

[Jeff Law]

On 10/26/2012 08:51 PM, Siddhesh Poyarekar wrote:
> On Fri, 26 Oct 2012 11:55:02 -0600, Jeff wrote:
>> Presumably there's some reason why you couldn't use the
>> INTERNAL_SYSCALL mechanisms for the s390 lll_futex_timed_wait_bitset?
>
> No technical reason.  It's just that all of the functions in the s390
> lowlevellock.h do the syscall directly, so I wrote it that way to
> maintain uniformity.  Most (all?) of the lll_futex_* functions could
> probably be rewritten as INTERNAL_SYSCALLs and moved into a common
> header as a future cleanup.
Understood and I agree with keeping a uniform style.

However, if it was in the INTERNAL_SYSCALL form I'd be a lot more 
comfortable approving it since I don't know s390 assembly :-)  However, 
it shouldn't be to terrible to have the INTERNAL_SYSCALL definition 
handy and verify your code is doing the same thing.

jeff