[PATCH][SH] SH CFI directives patch, revised

Kaz Kojima kkojima@rr.iij4u.or.jp
Mon May 28 04:16:00 GMT 2012


Thomas Schwinge <thomas@codesourcery.com> wrote:
>> 3) The SYSCALL_ERROR_HANDLER macro in
>> sysdeps/unix/sysv/linux/sh/sysdep.h has been changed to use CFI
>> directives to mark r12's save/restore.  The RTLD_PRIVATE_ERRNO version
>> is not dealt with, because simply, r12 there is never saved.
> 
> Hmm, I don't quite understand how that code can get away with not
> preserving r12 -- Kaz, do you have an explanation?  The code in question:

I don't remember any explanation.  Maybe just my oversight.
I agree that r12 should be preserved there.

Regards,
	kaz



More information about the Libc-alpha mailing list