[PATCH 8/9] mktime: avoid signed integer overflow

Paul Eggert eggert@cs.ucla.edu
Wed May 23 22:10:00 GMT 2012


On 05/23/2012 11:37 AM, Roland McGrath wrote:
> I don't understand why that doesn't introduce an off-by-one error,

ABS_DIFF doesn't need to be exactly |DIFF|; an approximation
is fine.  To clarify this I changed its name to APPROX_ABS_DIFF
and pushed it, along with the other changes you okayed.
Thanks for the review.  I'll merge these changes into gnulib now.

By the way, the & versus && business was to save about a few bytes'
worth of code on x86 (GCC 4.7.0 -O2) but it's not worth the
hassle of commenting this so I changed it to && as you suggested.



More information about the Libc-alpha mailing list