[PATCH] We no longer have foo.s files in the tree.

Roland McGrath roland@hack.frob.com
Mon May 21 20:30:00 GMT 2012


> On Sun, May 20, 2012 at 9:52 PM, David Miller <davem@davemloft.net> wrote:
> >
> > Committed to master.
> >
> >        * Makerules (sysd-rules): Remove .s from asm.
> 
> What is someone adds a *.s, what happens now?

It won't be built.

> Should we have a pre-commit hook that prevents this?

It wouldn't hurt but I don't think there's really any reason to bother,
especially since we don't have any hooks that do anything at all like that
(i.e. glibc-specific content restrictions) now.  If such a change is
reviewed properly, someone will catch it; if such a change is tested
properly, it won't work until it's fixed.



More information about the Libc-alpha mailing list