[PATCH] Fix sunrpc static library

[Andreas Jaeger]

On 05/19/2012 01:03 AM, Roland McGrath wrote:
>> 	* include/libc-symbols.h (libc_sunrpc_symbol): Define.
>
> "New macro", please.
>
>> 	* sunrpc/svc_simple.c: Support export of registerrpc for static
>> 	library.
>> 	* sunrpc/xcrypt.c: Support export of passwd2des for static
>> 	library.
>
> "Use it for registerrpc", please.
>
>> +#ifdef LINK_OBSOLETE_RPC
>> +/* Export symbol also for linking with static library. */
>
> Two spaces after the sentence.  I'd say:
>
> /* Export the symbol for both static and dynamic linking.  */
>
>> +/* Export symbol only in shared libc. */
>
> Two spaces here too.  And I'd say:
>
> /* Export the symbol only for shared-library compatibility.  */
>
> (The point being that it's not just that it's usable in the static library,
> but also that it will have a default symbol version binding.)

thanks for the review.

> Hmm.  Arguably this should be in shlib-compat.h instead, since
> compat_symbol is only there.

I can move it, if you think this is better. strong_alias is defined in 
libc-symbols and that code has already some defines similar to this one. 
Do you prefer shlib-compat.h? I don't see a better place - unless we 
create a new include file just for this case which seems overkill to me,

Andreas
-- 
  Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
   SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
    GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
     GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126