[PATCH] Fix warnings on i686

[Carlos O'Donell]

On Thu, May 17, 2012 at 11:20 AM, Andreas Jaeger <aj@suse.de> wrote:
>
> I noticed the following two warnings compiling glibc on Linux/i686:
>
> ../sysdeps/i386/dl-machine.h:336:30: warning: unused variable ‘refsym’ [-Wunused-variable]
> rtld.c:1435:3: warning: implicit declaration of function ‘_dl_discover_osversion’ [-Wimplicit-function-declaration]
>
> The file ./sysdeps/unix/sysv/linux/dl-sysdep.h had a change to "Don't
> declare _dl_discover_osversion only for older kernels." which is missing
> in the file ./nptl/sysdeps/unix/sysv/linux/i386/i686/dl-sysdep.h.
>
> For dl-machine.h it's moving refsym inside ifndef RTLD_BOOTSTRAP.
>
> Tested on Linux/i686.
>
> Ok to commit?
>
> Andreas
>
> for nptl:
> 2012-05-17  Andreas Jaeger  <aj@suse.de>
>
>        * sysdeps/unix/sysv/linux/i386/i686/dl-sysdep.h
>        (HAVE_DL_DISCOVER_OSVERSION): Don't declare _dl_discover_osversion
>        only for older kernels.
>
> 2012-05-17  Andreas Jaeger  <aj@suse.de>
>
>        * sysdeps/i386/dl-machine.h (elf_machine_rel): Declare refsym only
>        when it is used.

This looks good to me.

Cheers,
Carlos.