PATCH: Add tst-mallocalign1

Carlos O'Donell carlos@systemhalted.org
Thu May 17 15:11:00 GMT 2012


On Thu, May 17, 2012 at 10:39 AM, H.J. Lu <hongjiu.lu@intel.com> wrote:
> Hi,
>
> This patch adds tst-mallocalign1 to test malloc alignment.  Tested on
> Linux/x86-64.  OK to install?
>
> Thanks.
>
>
> H.J.
> ---
>        * sysdeps/x86_64/Makefile (tests): Add tst-mallocalign1.
>        * sysdeps/x86_64/tst-mallocalign1.c: New file.

This looks good to me.

I trust you know the psABI requirement, so I didn't double check that.

I figure that if malloc/malloc.c (MALLOC_ALIGNMENT) changes to be
below the requirement that this test would trigger a regression?

At present we have ((2 * sizeof(size_t)) - 1) which should be (16 - 1)
and meet the required minimum.

Does that make sense?

Cheers,
Carlos.



More information about the Libc-alpha mailing list