[PATCH] #13594: Avoid race in nscd

Roland McGrath roland@hack.frob.com
Mon May 14 20:33:00 GMT 2012


> This is the same code as used in nscd/nscd_helper.c.

Ok.  It would be better to write a shared subroutine for it.
But that doesn't have to hold up this change.

> +    retval =  map->head->extra_data[NSCD_HST_IDX_CONF_TIMESTAMP];

Excess space here.

Fine to commit with that one nit fix.  If you want to break out the locking
loop into a subroutine first, I'd like that even better.


Thanks,
Roland



More information about the Libc-alpha mailing list