[PATCH] Make sunrpc code available for building again

[Andreas Jaeger]

On 05/09/2012 11:52 PM, Roland McGrath wrote:
>> +	* config.h.in (LINK_OBSOLETE_RPC): Add.
>
> Usual style is, "New macro."
>
>> +	* config.make.in (link-obsolete-rpc): Add.
>
> Usual style is, "New substituted variable."
>
>> +	* sunrpc/Makefile (headers)[link-obsolete-rpc]: Add rpc headers.
>
> Missing space before [.
>
>> +	* nis/Makefile (headers)[link-obsolete-rpc]: Add rpc headers.
>
> And here.
>
>> +	* sunrpc/Makefile (shared-only-routines): Remove, so that libc.a
>> +	contains the symbols.
>
> I'd say:
>
> 	* sunrpc/Makefile (shared-only-routines): Don't set it under
> 	[link-obsolete-rpc], so that libc.a contains the symbols.
>
>> +* Resurrect the RPC implementation in libc so that it can be used again for
>> +  compilation of new programs. It will be removed once TI-RPC can fully
>> +  replace the glibc RPC code. To use it, configure using
>> +  --enable-obsolete-rpc.
>
> Two spaces between sentences.  This makes it sound to me like it was
> removed entirely and is being put back.  I'd say:
>
> * New configure option --enable-obsolete-rpc makes the deprecated RPC
>    headers and functions available at compile time as they were before
>    version 2.14.  This option will be removed at some time in the future
>    after the TI-RPC library becomes fully sufficient for the needs of
>    existing applications.
>
>
> The substance of the change looks fine to me.

Roland, thanks a lot for the constructive and quick review, I'm 
committing this now,

Andreas
-- 
  Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
   SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
    GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
     GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126