[PATCH] Complete GB18030 charmap

Carlos O'Donell carlos@systemhalted.org
Wed May 9 23:43:00 GMT 2012


On Wed, May 9, 2012 at 6:36 PM, Andreas Schwab <schwab@linux-m68k.org> wrote:
> "Carlos O'Donell" <carlos@systemhalted.org> writes:
>
>> # the tst-table-from and tst-table-to programs scan the Unicode BMP only.
>                                                 ^^^^^^^^^^^^^^^^^^^^^^^^^
>
> That's why.

There are two test cases reported in the issue.

The patch doesn't fix the first test case:

printf "\xf0\xa0\xb3\x90\n" > bz11837-t1.txt
GCONV_PATH=/home/carlos/build/glibc/iconvdata ./elf/ld-linux.so.2
--library-path /home/carlos/build/glibc:/home/carlos/build/glibc/elf:/home/carlos/build/glibc/dlfcn
./iconv/iconv_prog -t GB18030 ./bz11837-t1.txt
./iconv/iconv_prog: illegal input sequence at position 0

It does fix the second:

printf '\x00\x00\xc5\x0B' > bz11837-t2.txt
GCONV_PATH=/home/carlos/build/glibc/iconvdata ./elf/ld-linux.so.2
--library-path /home/carlos/build/glibc:/home/carlos/build/glibc/elf:/home/carlos/build/glibc/dlfcn
./iconv/iconv_prog -f UCS-4BE -t GB18030 ./bz11837-t2.txt > t2-out.txt
hexdump t2-out.txt
0000000 3283 36da
0000004

Do we know if these test cases are correct?

Cheers,
Carlos.



More information about the Libc-alpha mailing list