How to do the sunrpc revert?

Andreas Jaeger aj@suse.com
Wed May 9 08:18:00 GMT 2012


I looked briefly at the sunrpc changes while waiting for more people to give 
their "Yes, do it" ;).

Fedora and openSUSE (not checked others) use a very simple patch (attached as 
glibc2.14-revert-sunrpc-removal.patch) that works but is more of a hack, e.g.
it does the following in include/libc-symbols.h:

-# define libc_hidden_nolink(name, version) hidden_nolink (name, libc, version)
+# define libc_hidden_nolink(name, version) hidden_def (name)

The full removal patch (attached as sunrpc-removal.patch) is rather large and
contains also whitespace changes which I propose not to revert.

Should we do a full revert of the patch or use the simple patch - or is there
some middle ground?

If we do a revert, what should not be reverted besides copyright lines
and whitespace changes?

I consider the simple patch a bit too hackish.

Andreas
-- 
 Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
  SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
    GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126
-------------- next part --------------
A non-text attachment was scrubbed...
Name: glibc2.14-revert-sunrpc-removal.patch
Type: text/x-patch
Size: 2841 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20120509/a8de6f19/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sunrpc-removal.patch
Type: text/x-patch
Size: 134105 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20120509/a8de6f19/attachment-0001.bin>


More information about the Libc-alpha mailing list