[PATCH] Do not delete make check-abi symlist files

Andreas Jaeger aj@suse.com
Thu May 3 18:21:00 GMT 2012


On 05/03/2012 06:30 PM, Roland McGrath wrote:
>> +ifdef subdir
>> +generated += $(foreach l,$(extra-libs),$l.symlist)
>> +endif
>
> Why does this need to be in 'ifdef subdir'?

It doesn't need to be, I just tested it works fine without

> The most concise way to write it is '$(extra-libs:=.symlist)'.
> Or use addsuffix if you think that is clearer (as Andreas S. suggested).

Now it's really short, thanks.

Ok now?

Andreas

2012-05-05  Andreas Jaeger  <aj@suse.de>,
	Roland McGrath <roland@hack.frob.com>

         * Makerules (.PRECIOUS): Add .symlist files.
         (generated): Add .symlist files.

diff --git a/Makerules b/Makerules
index de87ad6..ab734b4 100644
--- a/Makerules
+++ b/Makerules
@@ -1158,6 +1158,12 @@ ifeq ($(versioning),yes)

  vpath %.abilist $(+sysdep_dirs)

+# Make sure that symlist is not removed.
+.PRECIOUS: %.symlist
+#ifdef subdir
+generated += $(extra-libs:=.symlist)
+#endif
+
  check-abi-%: $(common-objpfx)config.make %.abilist $(objpfx)%.symlist
  	$(check-abi)
  check-abi-%: $(common-objpfx)config.make %.abilist 
$(common-objpfx)%.symlist

-- 
  Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
   SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
    GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
     GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126



More information about the Libc-alpha mailing list