[PATCH] Unbound alloca in crypt routines - V2

Jeff Law law@redhat.com
Fri Mar 30 15:53:00 GMT 2012


On 03/29/2012 04:36 PM, Carlos O'Donell wrote:
>
> OK to checkin if you...
>
> (1) Adjust the copyright year on each file.
Done.  I just realized I didn't bump the copyright on Siddhesh's patches 
from the last couple days.  I'll make sure to bump those as well as an 
independent checkin.


>
> and...
>
> (2) Always add alloca_used to the size passed to __libc_use_alloca
> even if alloca_used would equal 0, that way someone in the future
> won't accidentally make the mistake if putting an alloca *before* your
> first call to __libc_use_alloca and forget to fixup the other caller
> to include "alloca_used +".
Good point.  Done.

Committed.

Thanks,

Jeff



More information about the Libc-alpha mailing list