[PATCH] Unbound alloca in crypt routines

[Carlos O'Donell]

On Thu, Mar 29, 2012 at 1:28 PM, Jeff Law <law@redhat.com> wrote:
>>> +      if (__libc_use_alloca (key_len + __alignof__ (md5_uint32)))
>>> +       {
>>> +         tmp = (char *) alloca (key_len + __alignof__ (md5_uint32));
>>> +       }
>>
>>
>> Those { } aren't really necessary here (and in further code).
>
> Not strictly necessary.  However, I've found that keeping the if and else
> clauses at the same indention level makes the code easier to read.  I'll
> defer to the maintainers on this.

I agree. I prefer the braces.

Cheers,
Carlos.