[RESEND-2][PATCH][BZ 13761] Fix allocation in nss_compat for large number of memberships to a group

Andreas Jaeger aj@suse.com
Wed Mar 28 09:59:00 GMT 2012


On 03/26/2012 08:22 AM, Siddhesh Poyarekar wrote:
> Hi,
>
> Resending once again:
>
> nss_compat allocates buffer space on stack using alloca (and
> extend_alloca) for initgroup and keeps extending it to fit in larger
> lines. This breaks for cases where the number of members in a gorup
> are very large, causing the alloca reference to go beyond thread stack
> boundary. Attached patch falls back to malloc/free if the buffer size
> needed is beyond __libc_alloca_cutoff.

Please state in your submission how and where this was tested.

The patch itself looks fine to me but I'd like to hear about testing,

Andreas
-- 
  Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
   SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
    GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
     GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126



More information about the Libc-alpha mailing list