[PATCH 10/13] Move sysdeps/sparc/{,sparc32,sparc64}/elf files

Andreas Jaeger aj@suse.com
Fri Mar 23 20:47:00 GMT 2012


On 03/23/2012 09:30 PM, Roland McGrath wrote:
> In all cases where you merged a foo/elf/{configure,Makefile} into an
> existing foo/{configure,Makefile}, the elf/ one's contents should come
> first.  That's the existing order of evaluation of the separate files.
> Sorry I didn't catch this in looking at your patches.

Indeed, that's the bug Dave Miller run into.

I just did a diff of my patchset and reviewed it:

Looking at configure and Makefiles:
configure is independend, most the elf files check for "TLS support" and 
set PI_STATIC_AND_HIDDEN, so no need to reorder the patch IMO.

Makefiles: besides the sparc64 case, all other places look fine to me. 
For sysdeps/powerpc/powerpc64/Makefile the place I choose seems the 
logical one.

So, I don't see a further change needed,

Andreas
-- 
  Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
   SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
    GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
     GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126



More information about the Libc-alpha mailing list