[ PATCH] Fix typo in nss_getent

Andreas Jaeger aj@suse.com
Fri Mar 23 20:09:00 GMT 2012


On 03/23/2012 08:59 PM, Jeff Law wrote:
>
> __nss_getent has the following code fragment:
>
>
> if (*buffer == NULL)
> {
> *buffer_size = buflen;
> *buffer = malloc (*buffer_size);
> }
>
> while (buffer != NULL
> [ ... ]
>
> The "buffer != NULL" clause in the WHILE statement will be eliminated as
> it is always true (buffer was dereferenced in the prior IF statement,
> thus it can't be NULL at the WHILE statement).
>
> The original author clearly meant to test
> while (*buffer != NULL
> [... ]

The fix is fine - but please remember to update the copyright years as well.

Thanks,
Andreas

> 2012-03-23 Jeff Law <law@redhat.com>
>
> * nss/getnssent.c (__nss_getent): Fix typo.
>
>


-- 
  Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
   SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
    GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
     GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126



More information about the Libc-alpha mailing list