[patch] Fix linking ldconfig when --enable-static-nss (with ChangeLog)
Roland McGrath
roland@hack.frob.com
Thu Mar 22 21:11:00 GMT 2012
> [BZ #6528]
> * grp/Makefile, inet/Makefile, login/Makefile, nscd/Makefile,
> posix/Makefile, pwd/Makefile, rt/Makefile, sunrpc/Makefile: Do not
> set otherlibs for static NSS.
Say:
* grp/Makefile (otherlibs): Don't set it.
* inet/Makefile: Likewise.
etc.
> * nss/Makefile: Likewise. Include libnss_files in libc.a for
> --enable-static-nss. Remove special case for getent.
> * resolv/Makefile: Include libnss_dns in libc.a for
> --enable-static-nss.
These similarly need to be changed to mention what they are doing
specifically with the variable and target names, as per the usual
ChangeLog style.
> +ifeq ($(build-static-nss),yes)
> +routines += $(libnss_files-routines)
> +static-only-routines += $(libnss_files-routines)
> endif
The style here is to align the += with other such lines,
or else don't add any superfluous whitespace at all.
> +ifeq ($(build-static-nss),yes)
> +routines += $(libnss_dns-routines) $(libresolv-routines)
> +static-only-routines += $(libnss_dns-routines) $(libresolv-routines)
> endif
Same here.
Thanks,
Roland
More information about the Libc-alpha
mailing list