PATCH: Replace Elf64_XXX with ElfW(XXX) in dl-irel.h

H.J. Lu hjl.tools@gmail.com
Thu Mar 22 17:12:00 GMT 2012


On Thu, Mar 22, 2012 at 9:55 AM, Roland McGrath <roland@hack.frob.com> wrote:
>> +#define ELFW(type)   _ElfW (ELF, __ELF_NATIVE_CLASS, type)
>
> This warrants a comment along the lines of the one for ElfW.
>
> The substance of the change looks fine to me.
>

I added a comment:

/* We use this macro to refer to ELF macros independent of the native
   wordsize.  `ELFW(R_TYPE)' is used in place of `ELF32_R_TYPE' or
   `ELF64_R_TYPE'.  */
#define ELFW(type)      _ElfW (ELF, __ELF_NATIVE_CLASS, type)

Does it look OK?

Thanks.

-- 
H.J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libc-dl-irel.patch
Type: text/x-patch
Size: 1795 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20120322/2d10a97f/attachment.bin>


More information about the Libc-alpha mailing list