PATCH: Configure x86_64 in sysdeps/x86_64/preconfigure

[H.J. Lu]

On Wed, Mar 21, 2012 at 1:20 PM, Roland McGrath <roland@hack.frob.com> wrote:
>> 2012-03-21  H.J. Lu  <hongjiu.lu@intel.com>
>>
>>       * sysdeps/x86_64/preconfigure: New file.
>
> Should be:
>
>        * sysdeps/x86_64/preconfigure.in: New file.
>        * sysdeps/x86_64/preconfigure: New generated file.

Updated.

>> diff --git a/sysdeps/x86_64/preconfigure b/sysdeps/x86_64/preconfigure
>
> It's normal to omit the generated files when posting a patch.
>
>> +  AC_CACHE_CHECK(if we are building for x32, libc_cv_x32, [dnl
>
> The usual convention is something like:
>
> AC_CACHE_CHECK([whether $CC compiles in -mx32 mode by default], ...

$CC may not compile in -mx32 mode by default.  But we can set -mx32 in CFLAGS.

>> +cat > conftest.c <<\EOF
>> +#ifdef __LP64__
>> +# error not x32
>> +#endif
>> +EOF
>> +  dnl
>> +  if AC_TRY_COMMAND(${CC-cc} -c $CFLAGS $CPPFLAGS conftest.c 1>&AS_MESSAGE_LOG_FD); then
>
> Why not use AC_TRY_COMPILE?
>

I'd like to take $CFLAGS $CPPFLAGS into account, which aren't
used in AC_TRY_COMPILE.

Here is the updated patch.  OK to install?

Thanks.

-- 
H.J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libc-x86_64-2b.patch
Type: text/x-patch
Size: 999 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20120321/a3080e94/attachment.bin>