PATCH: Configure x86_64 in sysdeps/x86_64/preconfigure

H.J. Lu hjl.tools@gmail.com
Wed Mar 21 18:44:00 GMT 2012


On Wed, Mar 21, 2012 at 10:46 AM, Roland McGrath <roland@hack.frob.com> wrote:
>> I need to set machine, libc_cv_slibdir and libc_cv_localedir properly
>> for both x86-64 and x32.  For x86-64, machine should be x86_64/64
>> and for x32, machine should be x86_64/x32 so that proper sysdeps
>> directories will be used.  That leaves libc_cv_slibdir and libc_cv_localedir.
>> Should they be set in sysdeps/x86_64/preconfigure or
>> sysdeps/unix/sysv/linux/configure?
>
> machine belongs in preconfigure.  Nothing else does.
> Send an independent change just for that.
>
> The existing code for setting slibdir and localedir is in
> sysdeps/unix/sysv/linux/configure.  There it has common cases that apply to
> several 64-bit machines.  For localedir, that common case still applies to
> x32.  So I think the right things to do are:
>
> 1. Separate the logic in sysdeps/unix/sysv/linux/configure so that
>   it still handles localedir even if slibdir is already set.
> 2. Make that match x86_64* rather than just x86_64.
> 3. Add sysdeps/unix/sysv/linux/x86_64/x32/configure with similar logic
>   for setting slibdir/libdir to the x32 names.
>
> #1 can be its own patch.
> #2 and #3 can go together in one patch, or be two separate patches.
>
>

Here is a patcn to implement #1.  Tested on Linux/x86-64.  OK to install?

Thanks.

-- 
H.J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libc-x86_64-2.patch
Type: text/x-patch
Size: 1849 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20120321/12555a6c/attachment.bin>


More information about the Libc-alpha mailing list