PATCH: Use RXX_LP, LP_OP, LP_SIZE and ASM_ADDR in nptl

H.J. Lu hjl.tools@gmail.com
Sat Mar 17 19:33:00 GMT 2012


On Sat, Mar 17, 2012 at 12:07 PM, Andreas Jaeger <aj@suse.com> wrote:
> On 03/17/2012 05:36 PM, H.J. Lu wrote:
>>
>> Hi,
>>
>> This patch changes nptl x86-64 assembly codes to use RXX_LP, LP_OP,
>> LP_SIZE
>> and ASM_ADDR on long and pointers. It uses RXX_LP when operating on
>> registers which contain long and pointers.  It uses LP_OP when
>> operating memory operands which contain long and pointers.  It uses
>> LP_SIZE and ASM_ADD for pointer operations.
>
>
> Seeing these patches, I'm concerned that people working on x86-64 will break
> x32 with not using all the macros.

We need to be careful when writing x86-64 assembly codes.

> IMO it makes sense to document somewhere - perhaps in the glibc wiki? - how
> to write x86-64 code for glibc so that it works on x32 as well.
>
> HJ, would this be possible?
>

I will give it a try.

-- 
H.J.



More information about the Libc-alpha mailing list