question on sparc SHMLBA helper function

Roland McGrath roland@hack.frob.com
Fri Mar 16 23:16:00 GMT 2012


> It just seems to be a very poor way to detect an error return value.

Ok, that's what I kind of thought, but it looked so strange I could't
really tell.

Perhaps you can verify the safety of a change like that and then do it?

> All the INTERNAL_SYSCALL_ERROR_P bits should take care of things these
> days, and then the only return value we have to check for from
> INTERNAL_SYSCALL is "-1".

Seems cleaner to use INTERNAL_SYSCALL* directly.


Thanks,
Roland



More information about the Libc-alpha mailing list