PATCH: Use "unsigned long long int" in x86-64 __makecontext

H.J. Lu hjl.tools@gmail.com
Fri Mar 16 21:55:00 GMT 2012


On Fri, Mar 16, 2012 at 2:37 PM, Roland McGrath <roland@hack.frob.com> wrote:
>> I compared the assembly outputs for both x32 and x86-64.  There
>> are no differences between "long int" and "unsigned long int" vs.
>> "greg_t" on va_arg.  Here is the patch to use  greg_t exclusively.
>> OK to install?
>
> That code looks OK, though (greg_t) after (uintptr_t) is really superfluous
> since the target of the assignment is a greg_t anyway.

This is the patch I will check in. I removed  (greg_t) after
(uintptr_t).  There is
no difference in asm codes.

> But please remove the erroneous XXX comment too.
>
> This could be a separate change, but it seems wise to make tst-setcontext.c
> try some long int and uintptr_t arguments.
>

I will create a separate patch to remove XXX comments and
add some tests to stdlib/tst-setcontext.c.

Thanks.

-- 
H.J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libc-x32-makecontext.patch
Type: text/x-patch
Size: 3075 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20120316/4e484c1e/attachment.bin>


More information about the Libc-alpha mailing list