PATCH: Add x32 support to ldconfig

Roland McGrath roland@hack.frob.com
Fri Mar 16 18:42:00 GMT 2012


> 2012-03-16  H.J. Lu  <hongjiu.lu@intel.com>
> 
> 	* elf/cache.c (print_entry): Handle FLAG_X8664_LIBX32.
> 
> 	* sysdeps/generic/ldconfig.h (FLAG_X8664_LIBX32): New.

Drop that blank line and invert the order.  Say "New macro".

> 	* sysdeps/unix/sysv/linux/x86_64/dl-cache.h (add_system_dir): New
> 	Don't include <sysdeps/unix/sysv/linux/sparc/dl-cache.h>.

Write it like this:

	* sysdeps/unix/sysv/linux/x86_64/dl-cache.h:
	Don't include <sysdeps/unix/sysv/linux/sparc/dl-cache.h>.
	(add_system_dir): New macro.

> --- a/sysdeps/unix/sysv/linux/x86_64/readelflib.c
> +++ b/sysdeps/unix/sysv/linux/x86_64/readelflib.c
> @@ -35,8 +35,18 @@ process_elf_file (const char *file_name, const char *lib, int *flag,

While you're here, it seems appropriate to lift the e_machine sanity check
above the if and make it accept only EM_{386,X86_64} (unconditionally)
and EM_IA_64 (only for ELFCLASS64).


Thanks,
Roland



More information about the Libc-alpha mailing list