PATCH: Add x86-64 ffsl alias only if __LP64__ is defined

H.J. Lu hjl.tools@gmail.com
Fri Mar 16 18:18:00 GMT 2012


On Fri, Mar 16, 2012 at 10:56 AM, Roland McGrath <roland@hack.frob.com> wrote:
>> When __LP64__ isn't defined, ffsll != ffsl.  This patch adds the check
>> for __LP64__ when making ffsl alias.  OK to install?
>
> Assuming it's true that all supported GCC versions defined __LP64__,
> then it's OK with the nits below fixed.

__LP64__ was added in 2003 and we only allow GCC 4.3, which was
released in 2008, or newer.

http://gcc.gnu.org/ml/gcc-patches/2003-03/msg00780.html

All
>>       * sysdeps/x86_64/ffsll.c: Add ffsl alias only if __LP64__ is
>>       defined.
>
> Say "(ffsl): Define alias only under [__LP64__]."
>
>> -   Copyright (C) 1991,92,93,94,97,98,2001 Free Software Foundation, Inc.
>> +   Copyright (C) 1991,92,93,94,97,98,2001,2012
>> +   Free Software Foundation, Inc.
>
>      Copyright (C) 1991-2012 Free Software Foundation, Inc.
>

I will make the change when I check it in.

Thanks.



-- 
H.J.



More information about the Libc-alpha mailing list