PATCH: Sync time/mktime.c with gnulib

H.J. Lu hjl.tools@gmail.com
Thu Mar 15 23:44:00 GMT 2012


On Thu, Mar 15, 2012 at 4:21 PM, Roland McGrath <roland@hack.frob.com> wrote:
>> Instead of trying to fix this yourself, I suggest that you simply
>> sync from the upstream version of mktime.c, which is in gnulib.
>> gnulib mktime.c was changed some time ago so that it does not
>> assume that 'long int' is wide enough for the calculations in question.
>
> This is already on the communal list for generally harmonizing once-shared
> code with gnulib.  It doesn't seem like it should be up to HJ to deal with
> the particularities of mktime.  Since there is now a practical need for it,
> mktime seems like a good place to start on that overall effort.  It makes
> sense that it be led by someone who groks the particular gnulib code in
> question and its history, i.e. probably you.  As with all these cases,
> we're not going to accept an "update" to the gnulib version wholesale, but
> will need to consider each material change on its merits and have them
> justified as with all proposed libc changes.
>

Here is a patch to sync with gnulib.

Thanks.

-- 
H.J.
---
2012-03-15  H.J. Lu  <hongjiu.lu@intel.com>

	* time/mktime.c: Sync with gnulib mktime.c at commit
	a7967a2cf0998b6c157c7cf8e1d8d9d11dab30b0.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libc-mktime.patch
Type: text/x-patch
Size: 29875 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20120315/da020781/attachment.bin>


More information about the Libc-alpha mailing list