[PATCH v2] fix warnings in sys/select.h fortification with -Wsign-conversion

Carlos O'Donell carlos@systemhalted.org
Sat Jun 9 13:25:00 GMT 2012


On Fri, Jun 8, 2012 at 7:39 PM, Mike Frysinger <vapier@gentoo.org> wrote:
> On Friday 08 June 2012 19:12:20 Roland McGrath wrote:
>> > 2012-06-08  Mike Frysinger  <vapier@gentoo.org>
>> >
>> >     * misc/bits/select2.h (__FD_ELT): Cast d to unsigned long int.
>>
>> Put D in caps here.
>
> hmm, didn't realize we capped variable names in the changelog

It should be just like a comment and follow GNU Coding Standards
section 5.2 e.g. write it in upper case when you are speaking of the
value.

Cheers,
Carlos.



More information about the Libc-alpha mailing list