[PATCH 07/10] Copy i486 bits/string.h to x86_64 bits/string.h
H.J. Lu
hjl.tools@gmail.com
Mon Jun 4 19:42:00 GMT 2012
On Mon, Jun 4, 2012 at 12:18 PM, Roland McGrath <roland@hack.frob.com> wrote:
> I don't think we should be duplicating so much code in two files. I
> think it's the case that we effectively require i486 or newer nowadays
> (i.e. no i386-*-* configurations really work). At any rate, your
> change adds the #if test so that -march=i386 wouldn't use the inlines.
> So I think what you should do is first make the change to the file in
> place to add the #if test, and then move it to sysdeps/x86.
>
I think this is exactly what my patch does. The follow-up patch to remove
sysdeps/i386/i486/bits/string.h is at:
http://sourceware.org/ml/libc-alpha/2012-06/msg00149.html
--
H.J.
More information about the Libc-alpha
mailing list