[PATCH][BZ #14134] Fix iconv segfault while converting from IBM-930

Siddhesh Poyarekar siddhesh@redhat.com
Mon Jun 4 18:22:00 GMT 2012


On Mon, 4 Jun 2012 20:07:26 +0200, Petr wrote:
> 
>   Silly me, you are right. In that case, the first hunk of the patch
> looks good to me. The second is AIUI still redundant?
> 

Oh right, the second hunk is in fact redundant. I had added it in as an
analogous change without a test case to prove it. I also now understand
why you looked at the opposite conversion; sorry about that.

Updated patch attached.

Thanks,
Siddhesh

2012-05-23  Siddhesh Poyarekar  <siddhesh@redhat.com>

	* iconvdata/ibm930.c (BODY) [FROM_LOOP]: Check for invalid
	character 0xffff that matches the last element of the
	conversion table.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: iconv-fix.patch
Type: text/x-patch
Size: 555 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20120604/5d6b3faa/attachment.bin>


More information about the Libc-alpha mailing list