[PATCH] Declare set*id with warn_unused_result

Florian Weimer fweimer@redhat.com
Tue Jul 24 15:55:00 GMT 2012


On 07/24/2012 05:50 PM, Paul Eggert wrote:
> On 07/24/2012 08:37 AM, Florian Weimer wrote:
>> The Hurd implementation allocates a new port, so it can fail as well.
>
> That's too bad.  It certainly strengthens the argument for
> adding __wur.
>
> Is a new port added even for seteuid?  That is, would it make
> sense to add __wur for some of these system calls, but not others?

It seems so.  The wrappers in sysdeps/mach/hurd/setuid.c and 
sysdeps/mach/hurd/seteuid.c end up in the same kernel call, and that 
doesn't have a shortcut for shuffling the UIDs around.

-- 
Florian Weimer / Red Hat Product Security Team




More information about the Libc-alpha mailing list