[PATCH] Take 2: Fix false positives in tst-pthread-getattr test case

Siddhesh Poyarekar siddhesh@redhat.com
Fri Jul 20 15:59:00 GMT 2012


On Fri, 20 Jul 2012 11:13:33 -0400, Carlos wrote:
> > 2012-07-20  Siddhesh Poyarekar  <siddhesh@redhat.com>
> > 
> > 	* tst-pthread-getattr.c (MAX_STACK_SIZE): New max cap for
> > stack size.
> 
> I see nothing in your comments that mentions this is a workaround
> to a kernel problem? We should document in the test case comments
> *why* we are doing this, thus future maintainers can decide to remove
> the code once the kernel is fixed.
> 
> Does that make sense?
> 

My fault -- my email blurb was incorrect. While the original concern
was the kernel behaviour that we saw, we would still need the max cap
since RLIMIT_STACK could actually be unlimited or very high, causing
this failure. I tried to focus on tying in the previous communication
threads and forgot to mention this point anywhere except in the patch.

Regards,
Siddhesh



More information about the Libc-alpha mailing list