[PATCH] Define secure_getenv (v2)

Florian Weimer fweimer@redhat.com
Fri Jul 20 07:46:00 GMT 2012


On 07/19/2012 09:47 PM, Roland McGrath wrote:
>> 	* inet/ruserpass.c (ruserpass): Rename __secure_getenv to
>> 	secure_getenv.
>> 	* malloc/mtrace.c (mtrace): Likewise.
>> 	* sysdeps/mach/hurd/tmpfile.c (__tmpfile): Likewise.
>> 	* sysdeps/posix/libc_fatal.c (__libc_fatal): Likewise.  Update
>> 	copyright years.
>> 	* sysdeps/posix/sysconf.c (__sysconf__check_spec): Likewise.
>> 	* sysdeps/posix/tempname.c: Likewise.  Evaluatue
>> 	HAVE_SECURE_GETENV.
>> 	* sysdeps/unix/sysv/linux/libc_fatal.c (__libc_message): Rename
>> 	__secure_getenv to secure_getenv.  Update copyright years.
>>
>> 	* hesiod/hesiod.c (hesiod_init): Use __libc_secure_getenv.
>
> All these internal references should be using an internal name
> such as __libc_secure_getenv.  It's not kosher for these things
> to refer to a nonstandard name that doesn't start with __.

Oh, will fix.  Is this about static linking?

The existing sources do not follow this rule in all cases, so I assumed 
it was expendable.

-- 
Florian Weimer / Red Hat Product Security Team




More information about the Libc-alpha mailing list