[tile] support openat() in not-cancel.h

Roland McGrath roland@hack.frob.com
Fri Jan 27 23:45:00 GMT 2012


> The problem is that there's no model for the dozen-odd files in
> sysdeps/unix/sysv/linux/ to get the correct version of "not-cancel.h"; they
> will all include the standard one, and break on Linux architectures using
> the new asm-generic API.  So, naively, we'd need to duplicate about 2,700
> lines of code into sysdeps/unix/sysv/linux/generic/ to avoid modifying
> not-cancel.h.
> 
> An alternative would be to move not-cancel.h somewhere overrideable by
> architectures.

Unless I'm missing something, there is no such problem.  All the instances
use '#include <not-cancel.h>', not '#include "not-cancel.h"'.  That means
the one in the most-specific sysdeps directory will always be the one used.

Oops, I found one instance: sysdeps/unix/sysv/linux/grantpt.c uses "".
That should be fixed.


Thanks,
Roland



More information about the Libc-alpha mailing list