Add testcase for bug 5794 (incorrect expm1 overflow)

Carlos O'Donell carlos@systemhalted.org
Wed Feb 29 18:23:00 GMT 2012


On Wed, Feb 29, 2012 at 12:47 PM, Joseph S. Myers
<joseph@codesourcery.com> wrote:
> Bug 5794 (incorrect expm1 overflow) was fixed in 2008, but without a
> testcase being added to the testsuite.  I propose this patch to add
> such a testcase (which I've verified did indeed fail with old glibc).
>
> 2012-02-29  Joseph Myers  <joseph@codesourcery.com>
>
>        * math/libm-test.inc (expm1_test): Add test for bug 5794.
>        * sysdeps/i386/fpu/libm-test-ulps: Update.
>        * sysdeps/x86_64/fpu/libm-test-ulps: Likewise.

Add a BZ entry in the ChangeLog instead of in comment?

If we get into the habit of using a BZ entry for all changes related
to the bug then when we turn on the committ<->bugzilla integration
for git we'll get nice updates automatically in the issue.

Otherwise looks OK to me.

Cheers,
Carlos.



More information about the Libc-alpha mailing list