[PATCH] Always set l_used for vDSO (BZ #13706)

[Carlos O'Donell]

On Fri, Feb 24, 2012 at 4:26 PM, Andreas Schwab <schwab@linux-m68k.org> wrote:
> "Carlos O'Donell" <carlos@systemhalted.org> writes:
>
>> On Fri, Feb 24, 2012 at 1:02 PM, Andreas Schwab <schwab@linux-m68k.org> wrote:
>>> Marek Polacek <polacek@redhat.com> writes:
>>>
>>>> +$(objpfx)tst-unused-dep.out: $(objpfx)testobj1.so
>>>> +     LD_TRACE_LOADED_OBJECTS=1 \
>>>> +     LD_DEBUG=unused \
>>>> +     $(elf-objpfx)${rtld-installed-name} \
>>>> +       --library-path $(rpath-link)$(patsubst %,:%,$(sysdep-library-path)) \
>>>> +       $< | grep -E "linux-(gate|vdso)(32|64)?.so.1" > $@ || :
>>>
>>> IMHO any output should be considered a failure.  You don't know how
>>> future VDSOs will be named.
>>
>> ... and it fails, and we notice, and fix it.
>
> You won't notice.
>
>> Test don't need to be future proof they just need to fail safe.
>
> This test is not fail safe.

Andreas,

Could you please clarify.

Are you saying that the test will not fail in the future if the VDSO
name changes?

Cheers,
Carlos.