[PATCH] vfprintf: validate nargs and maybe allocate from heap

Paul Eggert eggert@cs.ucla.edu
Tue Feb 7 21:43:00 GMT 2012


Thanks, that patch looks good to me; I don't see any technical
problems with it.  One minor stylistic nit that I didn't
notice last time:

> +    bytes_per_arg = sizeof (*args_value) + sizeof (*args_size)
> +                    + sizeof (*args_type);

The typical GNU style is to put parentheses around expressions that cross
line boundaries like that, e.g.,:

    bytes_per_arg = (sizeof (*args_value) + sizeof (*args_size)
                     + sizeof (*args_type));

This works better with Emacs.



More information about the Libc-alpha mailing list