[PATCH] vfprintf: validate nargs and maybe allocate from heap

Kees Cook kees@outflux.net
Mon Feb 6 17:42:00 GMT 2012


On Mon, Feb 06, 2012 at 04:18:52PM +0100, Andreas Schwab wrote:
> Paul Eggert <eggert@cs.ucla.edu> writes:
> 
> >   all_done:
> >     if (__builtin_expect (args_malloced != NULL, 0))
> >       free (args_malloced);
> 
> No need for the NULL check.

Ah, perhaps I misunderstood earlier style requirements. I was told not to
use implicit NULL tests. What're the other conventions around that?

Thanks,

-Kees

-- 
Kees Cook                                            @outflux.net



More information about the Libc-alpha mailing list