PATCH: BZ #14664: changing prefix breaks "make check-abi-libc"

Siddhesh Poyarekar siddhesh@redhat.com
Mon Dec 10 05:26:00 GMT 2012


> Could you please explain how this is different than just deleting the symbol?
> 
> Your changes make the test for this particular symbol a tautology.
> 
> You check to see that the size is the size you set which is always true.
> 
> The check you want is to see if the size you set matches the expected ABI size.
> 

In case of a prefix + a constant in a data symbol, the latter should
be unchanging from the viewpoint of glibc, while the former is the
responsibility of the distribution.  IMO, trying to check if some
prefix is a pre-computed value is not a sensible ABI check from the
glibc point of view.



More information about the Libc-alpha mailing list