[PATCH] settimeofday with NULL tv

Jeff Law law@redhat.com
Mon Dec 3 19:17:00 GMT 2012


On 12/03/2012 12:13 PM, David Miller wrote:
> From: Jeff Law <law@redhat.com>
> Date: Mon, 03 Dec 2012 12:04:08 -0700
>
>>
>> settimeofday (NULL, tz) is used by systemd (and perhaps other code) to
>> change the kernel timezone.  Unfortunately, glibc marks the first
>> argument as must-be-nonnull.  This causes static analyzers to issue
>> incorrect diagnostics for such uses of settimeofday.
>>
>> This patch removes the __nonnull attribute and the bogus diagnostics
>> no longer are issued.
>
> This looks fine to me.
Installed.  Thanks.
jeff



More information about the Libc-alpha mailing list