Testsuite races

Jeff Law law@redhat.com
Thu Aug 16 04:34:00 GMT 2012


On 08/15/2012 12:55 PM, Roland McGrath wrote:
>> It looks like it's just tst-codeset, tst-gettext3 and tst-gettext5 which
>> conflict on ${objpfx}domaindir/de_DE/LC_MESSAGES/codeset.mo
>>
>> Changing the .sh file to look like:
>>
>> (
>>     flock 200
>>     [ generate data & run test ]
>> ) 200>${objpfx}lockfile
>>
>> In each of the three tests seems to do the trick.  Similarly creating a
>> dependency in the Makefile where tst-gettext3.out depends on
>> tst-codeset.out and tst-gettext5.out depends on tst-gettext3.out works
>> just as well.
>
> The right answer is to have makefile rules to generate .../codeset.mo
> and have each of those .out targets depend on the file directly.
>
> With that, it looks like these tests won't need shell script wrappers at
> all, just the vanilla pattern rule should dtrt.
Works for me.  Expect a patch shortly.

jeff



More information about the Libc-alpha mailing list